diff options
author | Paolo Bonzini <pbonzini@redhat.com> | 2017-01-12 15:02:32 +0100 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2017-01-12 15:17:13 +0100 |
commit | 33ab91103b3415e12457e3104f0e4517ce12d0f3 (patch) | |
tree | 61bb5323aea25c0f3dd96d8a9891106898d28cad /kernel | |
parent | 546d87e5c903a7f3ee7b9f998949a94729fbc65b (diff) | |
download | op-kernel-dev-33ab91103b3415e12457e3104f0e4517ce12d0f3.zip op-kernel-dev-33ab91103b3415e12457e3104f0e4517ce12d0f3.tar.gz |
KVM: x86: fix emulation of "MOV SS, null selector"
This is CVE-2017-2583. On Intel this causes a failed vmentry because
SS's type is neither 3 nor 7 (even though the manual says this check is
only done for usable SS, and the dmesg splat says that SS is unusable!).
On AMD it's worse: svm.c is confused and sets CPL to 0 in the vmcb.
The fix fabricates a data segment descriptor when SS is set to a null
selector, so that CPL and SS.DPL are set correctly in the VMCS/vmcb.
Furthermore, only allow setting SS to a NULL selector if SS.RPL < 3;
this in turn ensures CPL < 3 because RPL must be equal to CPL.
Thanks to Andy Lutomirski and Willy Tarreau for help in analyzing
the bug and deciphering the manuals.
Reported-by: Xiaohan Zhang <zhangxiaohan1@huawei.com>
Fixes: 79d5b4c3cd809c770d4bf9812635647016c56011
Cc: stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions