diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2012-03-23 13:36:42 -0700 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2012-03-23 13:36:42 -0700 |
| commit | 275029353953c2117941ade84f02a2303912fad1 (patch) | |
| tree | 35e49f7b6d288f5ff74c5c95533e4353c587cd7d /kernel | |
| parent | c16fa4f2ad19908a47c63d8fa436a1178438c7e7 (diff) | |
| download | op-kernel-dev-275029353953c2117941ade84f02a2303912fad1.zip op-kernel-dev-275029353953c2117941ade84f02a2303912fad1.tar.gz | |
ioat: fix size of 'completion' for Xen
Starting with v3.2 Jonathan reports that Xen crashes loading the ioatdma
driver. A debug run shows:
ioatdma 0000:00:16.4: desc[0]: (0x300cc7000->0x300cc7040) cookie: 0 flags: 0x2 ctl: 0x29 (op: 0 int_en: 1 compl: 1)
...
ioatdma 0000:00:16.4: ioat_get_current_completion: phys_complete: 0xcc7000
...which shows that in this environment GFP_KERNEL memory may be backed
by a 64-bit dma address. This breaks the driver's assumption that an
unsigned long should be able to contain the physical address for
descriptor memory. Switch to dma_addr_t which beyond being the right
size, is the true type for the data i.e. an io-virtual address
inidicating the engine's last processed descriptor.
[stable: 3.2+]
Cc: <stable@vger.kernel.org>
Reported-by: Jonathan Nieder <jrnieder@gmail.com>
Reported-by: William Dauchy <wdauchy@gmail.com>
Tested-by: William Dauchy <wdauchy@gmail.com>
Tested-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions
