diff options
author | David Miller <davem@davemloft.net> | 2007-09-11 15:23:50 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-09-11 17:21:20 -0700 |
commit | f629307c857c030d5a3dd777fee37c8bb395e171 (patch) | |
tree | 872077db1924672104f8e1267f53bfa70f79b13c /kernel | |
parent | 179c85ea53bef807621f335767e41e23f86f01df (diff) | |
download | op-kernel-dev-f629307c857c030d5a3dd777fee37c8bb395e171.zip op-kernel-dev-f629307c857c030d5a3dd777fee37c8bb395e171.tar.gz |
tty: termios locking functions break with new termios type
I ran into a few problems.
n_tty_ioctl() for instance:
drivers/char/tty_ioctl.c:799: error: $,1rxstruct termios$,1ry has no
member named $,1rxc_ispeed$,1ry
This is calling the copy interface that is supposed to be using
a termios2 when the new interfaces are defined, however:
case TIOCGLCKTRMIOS:
if (kernel_termios_to_user_termios((struct termios __user *)arg, real_tty->termios_locked))
return -EFAULT;
return 0;
This is going to write over the end of the userspace
structure by a few bytes, and wasn't caught by you yet
because the i386 implementation is simply copy_to_user()
which does zero type checking.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions