diff options
| author | Yuanhan Liu <yuanhan.liu@linux.intel.com> | 2012-06-16 12:40:55 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-06-16 08:36:03 -0700 |
| commit | b56a39ac263e5b8cafedd551a49c2105e68b98c2 (patch) | |
| tree | 0dbbe8929783ab347b3d40d4ed79ea87d5b3966d /kernel | |
| parent | 4a77a5a06ec66ed05199b301e7c25f42f979afdc (diff) | |
| download | op-kernel-dev-b56a39ac263e5b8cafedd551a49c2105e68b98c2.zip op-kernel-dev-b56a39ac263e5b8cafedd551a49c2105e68b98c2.tar.gz | |
printk: return -EINVAL if the message len is bigger than the buf size
Just like what devkmsg_read() does, return -EINVAL if the message len is
bigger than the buf size, or it will trigger a segfault error.
Acked-by: Kay Sievers <kay@vrfy.org>
Acked-by: Fengguang Wu <wfg@linux.intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/printk.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/printk.c b/kernel/printk.c index 572730b..a2276b9 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -880,7 +880,9 @@ static int syslog_print(char __user *buf, int size) syslog_seq++; raw_spin_unlock_irq(&logbuf_lock); - if (len > 0 && copy_to_user(buf, text, len)) + if (len > size) + len = -EINVAL; + else if (len > 0 && copy_to_user(buf, text, len)) len = -EFAULT; kfree(text); |
