summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorPaul E. McKenney <paulmck@us.ibm.com>2006-01-08 01:01:38 -0800
committerLinus Torvalds <torvalds@g5.osdl.org>2006-01-08 20:13:40 -0800
commit2d89c929078588aa9b9c674ef03ee9aa816b59b8 (patch)
tree129971e5c75545c53236be294f521ec6e7021a2d /kernel
parente56d090310d7625ecb43a1eeebd479f04affb48b (diff)
downloadop-kernel-dev-2d89c929078588aa9b9c674ef03ee9aa816b59b8.zip
op-kernel-dev-2d89c929078588aa9b9c674ef03ee9aa816b59b8.tar.gz
[PATCH] Simpler signal-exit concurrency handling
Some simplification in checking signal delivery against concurrent exit. Instead of using get_task_struct_rcu(), which increments the task_struct reference count, check the reference count after acquiring sighand lock. Signed-off-by: "Paul E. McKenney" <paulmck@us.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/signal.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/kernel/signal.c b/kernel/signal.c
index 64737c7..9b6fda5 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1102,18 +1102,19 @@ int group_send_sig_info(int sig, struct siginfo *info, struct task_struct *p)
retry:
ret = check_kill_permission(sig, info, p);
- if (!ret && sig && (sp = p->sighand)) {
- if (!get_task_struct_rcu(p))
- return -ESRCH;
+ if (!ret && sig && (sp = rcu_dereference(p->sighand))) {
spin_lock_irqsave(&sp->siglock, flags);
if (p->sighand != sp) {
spin_unlock_irqrestore(&sp->siglock, flags);
- put_task_struct(p);
goto retry;
}
+ if ((atomic_read(&sp->count) == 0) ||
+ (atomic_read(&p->usage) == 0)) {
+ spin_unlock_irqrestore(&sp->siglock, flags);
+ return -ESRCH;
+ }
ret = __group_send_sig_info(sig, info, p);
spin_unlock_irqrestore(&sp->siglock, flags);
- put_task_struct(p);
}
return ret;
OpenPOWER on IntegriCloud