summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@g5.osdl.org>2005-10-01 11:04:18 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2005-10-01 11:04:18 -0700
commit14bf01bb0599c89fc7f426d20353b76e12555308 (patch)
tree4d9c164faaff5df25044b15afa235debc96091dc /kernel
parentfd2e54b35bd70d11c160ded4834e2378e915356e (diff)
downloadop-kernel-dev-14bf01bb0599c89fc7f426d20353b76e12555308.zip
op-kernel-dev-14bf01bb0599c89fc7f426d20353b76e12555308.tar.gz
Fix inequality comparison against "task->state"
We should always use bitmask ops, rather than depend on some ordering of the different states. With the TASK_NONINTERACTIVE flag, the inequality doesn't really work. Oleg Nesterov argues (likely correctly) that this test is unnecessary in the first place. However, the minimal fix for now is to at least make it work in the presense of TASK_NONINTERACTIVE. Waiting for consensus from Roland & co on potential bigger cleanups. Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/exit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/exit.c b/kernel/exit.c
index ee6d8b8..4307773 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1203,7 +1203,7 @@ static int wait_task_stopped(task_t *p, int delayed_group_leader, int noreap,
exit_code = p->exit_code;
if (unlikely(!exit_code) ||
- unlikely(p->state > TASK_STOPPED))
+ unlikely(p->state & TASK_TRACED))
goto bail_ref;
return wait_noreap_copyout(p, pid, uid,
why, (exit_code << 8) | 0x7f,
OpenPOWER on IntegriCloud