summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorJakub Kicinski <jakub.kicinski@netronome.com>2018-01-16 15:51:45 -0800
committerDaniel Borkmann <daniel@iogearbox.net>2018-01-17 01:15:05 +0100
commit0a2d28ff516c48a21c1e3be1ff7fba3e94248baa (patch)
tree65ee7b65a852fcc14ed31d3b11bf88abc17ef296 /kernel
parent4c38f74c9186e2bc32789ddab3a95ed384c695d7 (diff)
downloadop-kernel-dev-0a2d28ff516c48a21c1e3be1ff7fba3e94248baa.zip
op-kernel-dev-0a2d28ff516c48a21c1e3be1ff7fba3e94248baa.tar.gz
bpf: offload: make bpf_offload_dev_match() reject host+host case
Daniel suggests it would be more logical for bpf_offload_dev_match() to return false is either the program or the map are not offloaded, rather than treating the both not offloaded case as a "matching CPU/host device". This makes no functional difference today, since verifier only calls bpf_offload_dev_match() when one of the objects is offloaded. Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/bpf/offload.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c
index 453785f..a88cebf 100644
--- a/kernel/bpf/offload.c
+++ b/kernel/bpf/offload.c
@@ -395,10 +395,8 @@ bool bpf_offload_dev_match(struct bpf_prog *prog, struct bpf_map *map)
struct bpf_prog_offload *offload;
bool ret;
- if (!!bpf_prog_is_dev_bound(prog->aux) != !!bpf_map_is_dev_bound(map))
+ if (!bpf_prog_is_dev_bound(prog->aux) || !bpf_map_is_dev_bound(map))
return false;
- if (!bpf_prog_is_dev_bound(prog->aux))
- return true;
down_read(&bpf_devs_lock);
offload = prog->aux->offload;
OpenPOWER on IntegriCloud