summaryrefslogtreecommitdiffstats
path: root/kernel/trace
diff options
context:
space:
mode:
authorWang YanQing <udknight@gmail.com>2013-05-26 16:52:01 +0800
committerSteven Rostedt <rostedt@goodmis.org>2013-06-11 18:38:49 -0400
commit238ae93d699d59876b470bf6455de22bcfaa9a1b (patch)
treeabd8e269b1c48ffcd4eb4e9120edd051f58202cd /kernel/trace
parent8092e808a31839c502a52d391b15f31c1d8764f5 (diff)
downloadop-kernel-dev-238ae93d699d59876b470bf6455de22bcfaa9a1b.zip
op-kernel-dev-238ae93d699d59876b470bf6455de22bcfaa9a1b.tar.gz
tracing: Fix file mode of free_buffer
Commit 4f271a2a60c748599b30bb4dafff30d770439b96 (tracing: Add a proc file to stop tracing and free buffer) implement a method to free up ring buffer in kernel memory in the release code path of free_buffer's fd. Then we don't need read/write support for free_buffer, indeed we just have a dummy write fop, and don't implement read fop. So the 0200 is more reasonable file mode for free_buffer than the current file mode 0644. Link: http://lkml.kernel.org/r/20130526085201.GA3183@udknight Acked-by: Vaibhav Nagarnaik <vnagarnaik@google.com> Acked-by: David Sharp <dhsharp@google.com> Signed-off-by: Wang YanQing <udknight@gmail.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace')
-rw-r--r--kernel/trace/trace.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 1a41023..5f4a09c 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -5935,7 +5935,7 @@ init_tracer_debugfs(struct trace_array *tr, struct dentry *d_tracer)
trace_create_file("buffer_total_size_kb", 0444, d_tracer,
tr, &tracing_total_entries_fops);
- trace_create_file("free_buffer", 0644, d_tracer,
+ trace_create_file("free_buffer", 0200, d_tracer,
tr, &tracing_free_buffer_fops);
trace_create_file("trace_marker", 0220, d_tracer,
OpenPOWER on IntegriCloud