diff options
author | Li Zefan <lizf@cn.fujitsu.com> | 2009-08-17 16:52:53 +0800 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-08-17 11:25:09 +0200 |
commit | 97d53202a5670a08b79c8ef2e4fff1c1ee21317c (patch) | |
tree | 5ba925559a3031a833c5803d05a0a43e13ea1866 /kernel/trace/trace_stat.c | |
parent | ba8b3a40ba7e06d00c27508f090803af90e8dbbf (diff) | |
download | op-kernel-dev-97d53202a5670a08b79c8ef2e4fff1c1ee21317c.zip op-kernel-dev-97d53202a5670a08b79c8ef2e4fff1c1ee21317c.tar.gz |
trace_stat: Fix missing entry in stat file
One entry is missing in the output of a stat file.
The cause is, when stat_seq_start() is called the 2nd time, we
should start from the (pos-1)th elem in the rbtree but not pos,
because pos == 0 is the header.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <4A891A65.70009@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/trace/trace_stat.c')
-rw-r--r-- | kernel/trace/trace_stat.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c index 07c60b0..a4bb239 100644 --- a/kernel/trace/trace_stat.c +++ b/kernel/trace/trace_stat.c @@ -203,17 +203,21 @@ static void *stat_seq_start(struct seq_file *s, loff_t *pos) { struct stat_session *session = s->private; struct rb_node *node; + int n = *pos; int i; /* Prevent from tracer switch or rbtree modification */ mutex_lock(&session->stat_mutex); /* If we are in the beginning of the file, print the headers */ - if (!*pos && session->ts->stat_headers) - return SEQ_START_TOKEN; + if (session->ts->stat_headers) { + if (n == 0) + return SEQ_START_TOKEN; + n--; + } node = rb_first(&session->stat_root); - for (i = 0; node && i < *pos; i++) + for (i = 0; node && i < n; i++) node = rb_next(node); return node; |