diff options
| author | Steven Rostedt <srostedt@redhat.com> | 2011-07-05 11:36:06 -0400 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2011-07-07 11:19:18 -0400 |
| commit | e9dbfae53eeb9fc3d4bb7da3df87fa9875f5da02 (patch) | |
| tree | 2a389b9c6a5fe08d4fb3a9ca96e753244963e1d9 /kernel/trace/trace.h | |
| parent | 140fe3b1ab9c082182ef13359fab4ddba95c24c3 (diff) | |
| download | op-kernel-dev-e9dbfae53eeb9fc3d4bb7da3df87fa9875f5da02.zip op-kernel-dev-e9dbfae53eeb9fc3d4bb7da3df87fa9875f5da02.tar.gz | |
tracing: Fix bug when reading system filters on module removal
The event system is freed when its nr_events is set to zero. This happens
when a module created an event system and then later the module is
removed. Modules may share systems, so the system is allocated when
it is created and freed when the modules are unloaded and all the
events under the system are removed (nr_events set to zero).
The problem arises when a task opened the "filter" file for the
system. If the module is unloaded and it removed the last event for
that system, the system structure is freed. If the task that opened
the filter file accesses the "filter" file after the system has
been freed, the system will access an invalid pointer.
By adding a ref_count, and using it to keep track of what
is using the event system, we can free it after all users
are finished with the event system.
Cc: <stable@kernel.org>
Reported-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace.h')
| -rw-r--r-- | kernel/trace/trace.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index 229f859..f807407 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h @@ -677,6 +677,7 @@ struct event_subsystem { struct dentry *entry; struct event_filter *filter; int nr_events; + int ref_count; }; #define FILTER_PRED_INVALID ((unsigned short)-1) |
