summaryrefslogtreecommitdiffstats
path: root/kernel/timer.c
diff options
context:
space:
mode:
authorPavel Roskin <proski@gnu.org>2009-07-18 16:46:02 -0400
committerThomas Gleixner <tglx@linutronix.de>2009-07-18 23:11:43 +0200
commit4841158b26e28e1476eed84c7347c18f11317750 (patch)
treeca701f45ebf6088ab45f76e68f0ef74a03654532 /kernel/timer.c
parent78af08d90b8f745044b1274430bc4bc6b2b27aca (diff)
downloadop-kernel-dev-4841158b26e28e1476eed84c7347c18f11317750.zip
op-kernel-dev-4841158b26e28e1476eed84c7347c18f11317750.tar.gz
timer: Avoid reading uninitialized data
timer->expires may be uninitialized, so check timer_pending() before touching timer->expires to pacify kmemcheck. Signed-off-by: Pavel Roskin <proski@gnu.org> LKML-Reference: <20090718204602.5191.360.stgit@mj.roinet.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/timer.c')
-rw-r--r--kernel/timer.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/timer.c b/kernel/timer.c
index 0b36b9e..a7f07d5 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -714,7 +714,7 @@ int mod_timer(struct timer_list *timer, unsigned long expires)
* networking code - if the timer is re-modified
* to be the same thing then just return:
*/
- if (timer->expires == expires && timer_pending(timer))
+ if (timer_pending(timer) && timer->expires == expires)
return 1;
return __mod_timer(timer, expires, false, TIMER_NOT_PINNED);
OpenPOWER on IntegriCloud