summaryrefslogtreecommitdiffstats
path: root/kernel/time
diff options
context:
space:
mode:
authorAndreas Schwab <schwab@linux-m68k.org>2012-08-21 20:30:47 -0400
committerThomas Gleixner <tglx@linutronix.de>2012-08-22 10:42:13 +0200
commit85dc8f05c93c8105987de9d7e7cebf15a72ff4ec (patch)
tree5be946b9b6f5be3c20fa4c6692b3a4491b86b0a9 /kernel/time
parent784ffcbb96c3a97b4c64fd48b1dfe12ef3fcbcda (diff)
downloadop-kernel-dev-85dc8f05c93c8105987de9d7e7cebf15a72ff4ec.zip
op-kernel-dev-85dc8f05c93c8105987de9d7e7cebf15a72ff4ec.tar.gz
time: Fix casting issue in timekeeping_forward_now
arch_gettimeoffset returns a u32 value which when shifted by tk->shift can overflow. This issue was introduced with 1e75fa8be (time: Condense timekeeper.xtime into xtime_sec) Cast it to u64 first. Signed-off-by: Andreas Schwab <schwab@linux-m68k.org> Signed-off-by: John Stultz <john.stultz@linaro.org> Cc: Prarit Bhargava <prarit@redhat.com> Cc: Ingo Molnar <mingo@kernel.org> Link: http://lkml.kernel.org/r/1345595449-34965-3-git-send-email-john.stultz@linaro.org Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/time')
-rw-r--r--kernel/time/timekeeping.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 258164a..1dbf80e 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -277,7 +277,7 @@ static void timekeeping_forward_now(struct timekeeper *tk)
tk->xtime_nsec += cycle_delta * tk->mult;
/* If arch requires, add in gettimeoffset() */
- tk->xtime_nsec += arch_gettimeoffset() << tk->shift;
+ tk->xtime_nsec += (u64)arch_gettimeoffset() << tk->shift;
tk_normalize_xtime(tk);
OpenPOWER on IntegriCloud