summaryrefslogtreecommitdiffstats
path: root/kernel/signal.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@tv-sign.ru>2008-04-30 00:52:45 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2008-04-30 08:29:34 -0700
commit6ca25b551309eb1b1b41f83414a92f7472e0b23d (patch)
treea2c5785ec484ec997ac6a03d3fceae04e4d21795 /kernel/signal.c
parente442055193e4584218006e616c9bdce0c5e9ae5c (diff)
downloadop-kernel-dev-6ca25b551309eb1b1b41f83414a92f7472e0b23d.zip
op-kernel-dev-6ca25b551309eb1b1b41f83414a92f7472e0b23d.tar.gz
kill_pid_info: don't take now unneeded tasklist_lock
Previously handle_stop_signal(SIGCONT) could drop ->siglock. That is why kill_pid_info(SIGCONT) takes tasklist_lock to make sure the target task can't go away after unlock. Not needed now. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Cc: Roland McGrath <roland@redhat.com> Cc: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/signal.c')
-rw-r--r--kernel/signal.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/kernel/signal.c b/kernel/signal.c
index 115c04f..ce53ab1 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1039,9 +1039,6 @@ int kill_pid_info(int sig, struct siginfo *info, struct pid *pid)
struct task_struct *p;
rcu_read_lock();
- if (unlikely(sig_needs_tasklist(sig)))
- read_lock(&tasklist_lock);
-
retry:
p = pid_task(pid, PIDTYPE_PID);
if (p) {
@@ -1055,10 +1052,8 @@ retry:
*/
goto retry;
}
-
- if (unlikely(sig_needs_tasklist(sig)))
- read_unlock(&tasklist_lock);
rcu_read_unlock();
+
return error;
}
OpenPOWER on IntegriCloud