summaryrefslogtreecommitdiffstats
path: root/kernel/sched_idletask.c
diff options
context:
space:
mode:
authorPeter Zijlstra <a.p.zijlstra@chello.nl>2010-04-22 21:50:19 +0200
committerIngo Molnar <mingo@elte.hu>2010-04-23 11:02:02 +0200
commit74f5187ac873042f502227701ed1727e7c5fbfa9 (patch)
treeb200960d04b0a955aaf9a101d6f0a4ed34f07bb2 /kernel/sched_idletask.c
parent09a40af5240de02d848247ab82440ad75b31ab11 (diff)
downloadop-kernel-dev-74f5187ac873042f502227701ed1727e7c5fbfa9.zip
op-kernel-dev-74f5187ac873042f502227701ed1727e7c5fbfa9.tar.gz
sched: Cure load average vs NO_HZ woes
Chase reported that due to us decrementing calc_load_task prematurely (before the next LOAD_FREQ sample), the load average could be scewed by as much as the number of CPUs in the machine. This patch, based on Chase's patch, cures the problem by keeping the delta of the CPU going into NO_HZ idle separately and folding that in on the next LOAD_FREQ update. This restores the balance and we get strict LOAD_FREQ period samples. Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Acked-by: Chase Douglas <chase.douglas@canonical.com> LKML-Reference: <1271934490.1776.343.camel@laptop> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched_idletask.c')
-rw-r--r--kernel/sched_idletask.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/sched_idletask.c b/kernel/sched_idletask.c
index bea2b8f..9fa0f40 100644
--- a/kernel/sched_idletask.c
+++ b/kernel/sched_idletask.c
@@ -23,8 +23,7 @@ static void check_preempt_curr_idle(struct rq *rq, struct task_struct *p, int fl
static struct task_struct *pick_next_task_idle(struct rq *rq)
{
schedstat_inc(rq, sched_goidle);
- /* adjust the active tasks as we might go into a long sleep */
- calc_load_account_active(rq);
+ calc_load_account_idle(rq);
return rq->idle;
}
OpenPOWER on IntegriCloud