diff options
author | Max Krasnyansky <maxk@qualcomm.com> | 2008-07-15 20:56:26 -0700 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-07-18 13:23:18 +0200 |
commit | 39b0fad7121eace85770e7a4c6dc35dfd2879768 (patch) | |
tree | a5d85b06fd656ccb26c906c237fb45dccd46e18c /kernel/sched_debug.c | |
parent | e761b7725234276a802322549cee5255305a0930 (diff) | |
download | op-kernel-dev-39b0fad7121eace85770e7a4c6dc35dfd2879768.zip op-kernel-dev-39b0fad7121eace85770e7a4c6dc35dfd2879768.tar.gz |
cpu hotplug: Make cpu_active_map synchronization dependency clear
This goes on top of the cpu_active_map (take 2) patch.
Currently we depend on the stop_machine to provide nescessesary
synchronization for the cpu_active_map updates.
As Dmitry Adamushko pointed this is fragile and is not much clearer
than the previous scheme. In other words we do not want to depend on
the internal stop machine operation here.
So make the synchronization rules clear by doing synchronize_sched()
after clearing out cpu active bit.
Tested on quad-Core2 with:
while true; do
for i in 1 2 3; do
echo 0 > /sys/devices/system/cpu/cpu$i/online
done
for i in 1 2 3; do
echo 1 > /sys/devices/system/cpu/cpu$i/online
done
done
and
stress -c 200
No lockdep, preempt or other complaints.
Signed-off-by: Max Krasnyansky <maxk@qualcomm.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched_debug.c')
0 files changed, 0 insertions, 0 deletions