summaryrefslogtreecommitdiffstats
path: root/kernel/rcutree.c
diff options
context:
space:
mode:
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>2013-08-08 22:26:23 -0700
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>2013-09-23 09:16:13 -0700
commit591c6d1710cd73824057d08eda302cf2a7cfd18a (patch)
treedda4911c2001171f19cf09ed23ed652d43564114 /kernel/rcutree.c
parent88d6df612cc3c99f56cc18461fcc531c3a145544 (diff)
downloadop-kernel-dev-591c6d1710cd73824057d08eda302cf2a7cfd18a.zip
op-kernel-dev-591c6d1710cd73824057d08eda302cf2a7cfd18a.tar.gz
rcu: Flag lockless access to ->gp_flags with ACCESS_ONCE()
This commit applies ACCESS_ONCE() to an outside-of-lock access to ->gp_flags. Although it is hard to imagine any sane compiler messing this particular case up, the documentation benefits are substantial. Plus the definition of "sane compiler" grows ever looser. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Diffstat (limited to 'kernel/rcutree.c')
-rw-r--r--kernel/rcutree.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index 62b67b7..6d028fd 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -1481,7 +1481,7 @@ static int __noreturn rcu_gp_kthread(void *arg)
/* Handle grace-period start. */
for (;;) {
wait_event_interruptible(rsp->gp_wq,
- rsp->gp_flags &
+ ACCESS_ONCE(rsp->gp_flags) &
RCU_GP_FLAG_INIT);
if (rcu_gp_init(rsp))
break;
OpenPOWER on IntegriCloud