diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-02-02 07:52:54 -0800 |
|---|---|---|
| committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2012-02-21 09:06:10 -0800 |
| commit | 3c1b1ce00d2702d6be9b92233822e560f37ea780 (patch) | |
| tree | 302e888faea366f7caccd6ad946bdde6d8e9137e /kernel/rcutorture.c | |
| parent | bde23c6892878e48f64de668660778991bc2fb56 (diff) | |
| download | op-kernel-dev-3c1b1ce00d2702d6be9b92233822e560f37ea780.zip op-kernel-dev-3c1b1ce00d2702d6be9b92233822e560f37ea780.tar.gz | |
PTR_ERR should be called before its argument is cleared.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e,e1;
constant c;
@@
*e = c
... when != e = e1
when != &e
when != true IS_ERR(e)
*PTR_ERR(e)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reported-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Diffstat (limited to 'kernel/rcutorture.c')
| -rw-r--r-- | kernel/rcutorture.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c index ed1c72b..a89b381 100644 --- a/kernel/rcutorture.c +++ b/kernel/rcutorture.c @@ -1465,12 +1465,15 @@ rcu_torture_onoff(void *arg) static int __cpuinit rcu_torture_onoff_init(void) { + int ret; + if (onoff_interval <= 0) return 0; onoff_task = kthread_run(rcu_torture_onoff, NULL, "rcu_torture_onoff"); if (IS_ERR(onoff_task)) { + ret = PTR_ERR(onoff_task); onoff_task = NULL; - return PTR_ERR(onoff_task); + return ret; } return 0; } |
