summaryrefslogtreecommitdiffstats
path: root/kernel/printk.c
diff options
context:
space:
mode:
authorStephen Warren <swarren@nvidia.com>2012-05-10 16:14:33 -0600
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-05-10 15:36:59 -0700
commitf8450fca6ecdea38b5a882fdf6cd097e3ec8651c (patch)
treebd304f4638508c8a6879798384199b994cbb6c04 /kernel/printk.c
parentaf4681097b23fe9c63a03d774de7c742fa3a920e (diff)
downloadop-kernel-dev-f8450fca6ecdea38b5a882fdf6cd097e3ec8651c.zip
op-kernel-dev-f8450fca6ecdea38b5a882fdf6cd097e3ec8651c.tar.gz
printk: correctly align __log_buf
__log_buf must be aligned, because a 64-bit value is written directly to it as part of struct log. Alignment of the log entries is typically handled by log_store(), but this only triggers for subsequent entries, not the very first (or wrapped) entries. Cc: Kay Sievers <kay@vrfy.org> Signed-off-by: Stephen Warren <swarren@nvidia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/printk.c')
-rw-r--r--kernel/printk.c13
1 files changed, 6 insertions, 7 deletions
diff --git a/kernel/printk.c b/kernel/printk.c
index 572941d..8b027bd 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -227,8 +227,13 @@ static u32 clear_idx;
#define LOG_LINE_MAX 1024
/* record buffer */
+#if !defined(CONFIG_64BIT) || defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
+#define LOG_ALIGN 4
+#else
+#define LOG_ALIGN 8
+#endif
#define __LOG_BUF_LEN (1 << CONFIG_LOG_BUF_SHIFT)
-static char __log_buf[__LOG_BUF_LEN];
+static char __log_buf[__LOG_BUF_LEN] __aligned(LOG_ALIGN);
static char *log_buf = __log_buf;
static u32 log_buf_len = __LOG_BUF_LEN;
@@ -279,12 +284,6 @@ static u32 log_next(u32 idx)
return idx + msg->len;
}
-#if !defined(CONFIG_64BIT) || defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
-#define LOG_ALIGN 4
-#else
-#define LOG_ALIGN 8
-#endif
-
/* insert record into the buffer, discard old ones, update heads */
static void log_store(int facility, int level,
const char *dict, u16 dict_len,
OpenPOWER on IntegriCloud