summaryrefslogtreecommitdiffstats
path: root/kernel/power
diff options
context:
space:
mode:
authorImre Deak <imre.deak@intel.com>2014-10-24 20:29:10 +0300
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2014-10-27 18:42:26 +0100
commit94fb823fcb4892614f57e59601bb9d4920f24711 (patch)
tree3e7ea9191719304aeb6daff1be69a94b907aa7a0 /kernel/power
parent246ef766743618a7cab059d6c4993270075b173e (diff)
downloadop-kernel-dev-94fb823fcb4892614f57e59601bb9d4920f24711.zip
op-kernel-dev-94fb823fcb4892614f57e59601bb9d4920f24711.tar.gz
PM / Sleep: fix recovery during resuming from hibernation
If a device's dev_pm_ops::freeze callback fails during the QUIESCE phase, we don't rollback things correctly calling the thaw and complete callbacks. This could leave some devices in a suspended state in case of an error during resuming from hibernation. Signed-off-by: Imre Deak <imre.deak@intel.com> Cc: All applicable <stable@vger.kernel.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'kernel/power')
-rw-r--r--kernel/power/hibernate.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index a9dfa79..1f35a34 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -502,8 +502,14 @@ int hibernation_restore(int platform_mode)
error = dpm_suspend_start(PMSG_QUIESCE);
if (!error) {
error = resume_target_kernel(platform_mode);
- dpm_resume_end(PMSG_RECOVER);
+ /*
+ * The above should either succeed and jump to the new kernel,
+ * or return with an error. Otherwise things are just
+ * undefined, so let's be paranoid.
+ */
+ BUG_ON(!error);
}
+ dpm_resume_end(PMSG_RECOVER);
pm_restore_gfp_mask();
resume_console();
pm_restore_console();
OpenPOWER on IntegriCloud