summaryrefslogtreecommitdiffstats
path: root/kernel/module_signing.c
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2013-11-21 12:41:44 +0100
committerIngo Molnar <mingo@kernel.org>2013-11-27 11:04:53 +0100
commit32e475d76a3e40879cd9ee4f69b19615062280d7 (patch)
tree47752cc77813b3b732301e0908799ea1dcd85775 /kernel/module_signing.c
parent0515973ffb16c2852a1bb1df2ca1456556faaaa5 (diff)
downloadop-kernel-dev-32e475d76a3e40879cd9ee4f69b19615062280d7.zip
op-kernel-dev-32e475d76a3e40879cd9ee4f69b19615062280d7.tar.gz
sched: Expose preempt_schedule_irq()
Tony reported that aa0d53260596 ("ia64: Use preempt_schedule_irq") broke PREEMPT=n builds on ia64. Ok, wrapped my brain around it. I tripped over the magic asm foo which has a single need_resched check and schedule point for both sys call return and interrupt return. So you need the schedule_preempt_irq() for kernel preemption from interrupt return while on a normal syscall preemption a schedule would be sufficient. But using schedule_preempt_irq() is not harmful here in any way. It just sets the preempt_active bit also in cases where it would not be required. Even on preempt=n kernels adding the preempt_active bit is completely harmless. So instead of having an extra function, moving the existing one out of the ifdef PREEMPT looks like the sanest thing to do. It would also allow getting rid of various other sti/schedule/cli asm magic in other archs. Reported-and-Tested-by: Tony Luck <tony.luck@gmail.com> Fixes: aa0d53260596 ("ia64: Use preempt_schedule_irq") Signed-off-by: Thomas Gleixner <tglx@linutronix.de> [slightly edited Changelog] Signed-off-by: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/alpine.DEB.2.02.1311211230030.30673@ionos.tec.linutronix.de Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/module_signing.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud