summaryrefslogtreecommitdiffstats
path: root/kernel/livepatch
diff options
context:
space:
mode:
authorJiri Kosina <jkosina@suse.cz>2015-02-15 10:03:20 +0100
committerJiri Kosina <jkosina@suse.cz>2015-02-16 16:26:56 +0100
commite0b561ee78d82a4cc7792aa28fa4b1ea15325dcc (patch)
treee11dc662c90bc42ee17d358f0f79eb914dfbb119 /kernel/livepatch
parent1d9c5d79e6e4385aea6f69c23ba543717434ed70 (diff)
downloadop-kernel-dev-e0b561ee78d82a4cc7792aa28fa4b1ea15325dcc.zip
op-kernel-dev-e0b561ee78d82a4cc7792aa28fa4b1ea15325dcc.tar.gz
livepatch: fix format string in kobject_init_and_add()
kobject_init_and_add() takes expects format string for a name, so we better provide it in order to avoid infoleaks if modules craft their mod->name in a special way. Reported-by: Fengguang Wu <fengguang.wu@intel.com> Reported-by: Kees Cook <keescook@chromium.org> Acked-by: Seth Jennings <sjenning@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'kernel/livepatch')
-rw-r--r--kernel/livepatch/core.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index ff7f47d..69bf3aa 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -731,7 +731,7 @@ static int klp_init_func(struct klp_object *obj, struct klp_func *func)
func->state = KLP_DISABLED;
return kobject_init_and_add(&func->kobj, &klp_ktype_func,
- obj->kobj, func->old_name);
+ obj->kobj, "%s", func->old_name);
}
/* parts of the initialization that is done only when the object is loaded */
@@ -807,7 +807,7 @@ static int klp_init_patch(struct klp_patch *patch)
patch->state = KLP_DISABLED;
ret = kobject_init_and_add(&patch->kobj, &klp_ktype_patch,
- klp_root_kobj, patch->mod->name);
+ klp_root_kobj, "%s", patch->mod->name);
if (ret)
goto unlock;
OpenPOWER on IntegriCloud