diff options
author | Huacai Chen <chenhc@lemote.com> | 2013-04-07 02:14:14 +0000 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-04-08 22:10:40 +0200 |
commit | 6f389a8f1dd22a24f3d9afc2812b30d639e94625 (patch) | |
tree | 8b175282bdf49043dc57711e121ee603be8cb188 /kernel/kmod.c | |
parent | ec376a2ab97ec3be52ca282dc6ac102e805d1005 (diff) | |
download | op-kernel-dev-6f389a8f1dd22a24f3d9afc2812b30d639e94625.zip op-kernel-dev-6f389a8f1dd22a24f3d9afc2812b30d639e94625.tar.gz |
PM / reboot: call syscore_shutdown() after disable_nonboot_cpus()
As commit 40dc166c (PM / Core: Introduce struct syscore_ops for core
subsystems PM) say, syscore_ops operations should be carried with one
CPU on-line and interrupts disabled. However, after commit f96972f2d
(kernel/sys.c: call disable_nonboot_cpus() in kernel_restart()),
syscore_shutdown() is called before disable_nonboot_cpus(), so break
the rules. We have a MIPS machine with a 8259A PIC, and there is an
external timer (HPET) linked at 8259A. Since 8259A has been shutdown
too early (by syscore_shutdown()), disable_nonboot_cpus() runs without
timer interrupt, so it hangs and reboot fails. This patch call
syscore_shutdown() a little later (after disable_nonboot_cpus()) to
avoid reboot failure, this is the same way as poweroff does.
For consistency, add disable_nonboot_cpus() to kernel_halt().
Signed-off-by: Huacai Chen <chenhc@lemote.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'kernel/kmod.c')
0 files changed, 0 insertions, 0 deletions