diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2011-02-25 17:17:18 +0100 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2011-02-25 17:17:18 +0100 |
| commit | 1204e95689f9fbd245a4ce5c1b0cd0a9b77f8d25 (patch) | |
| tree | 7dafda97ffb9156853904873c1397ac2d2b5b9d7 /kernel/irq | |
| parent | fd4afaf33313d94f548cb09129ecba3dbab62931 (diff) | |
| download | op-kernel-dev-1204e95689f9fbd245a4ce5c1b0cd0a9b77f8d25.zip op-kernel-dev-1204e95689f9fbd245a4ce5c1b0cd0a9b77f8d25.tar.gz | |
genirq: Make warning in handle_percpu_event useful
The WARN_ON_ONCE in handle_percpu_event() which emits a warning when
an action handler returns with interrupts enabled is not really
useful. It does not reveal the interrupt number and handler function
which caused it. Make it WARN_ONCE() and add the information.
Reported-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/irq')
| -rw-r--r-- | kernel/irq/handle.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c index e099e9e..b110c83 100644 --- a/kernel/irq/handle.c +++ b/kernel/irq/handle.c @@ -64,7 +64,8 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action) res = action->handler(irq, action->dev_id); trace_irq_handler_exit(irq, action, res); - if (WARN_ON_ONCE(!irqs_disabled())) + if (WARN_ONCE(!irqs_disabled(),"irq %u handler %pF enabled interrupts\n", + irq, action->handler)) local_irq_disable(); switch (res) { |
