summaryrefslogtreecommitdiffstats
path: root/kernel/irq/handle.c
diff options
context:
space:
mode:
authorIngo Molnar <mingo@elte.hu>2008-12-26 19:02:20 +0100
committerIngo Molnar <mingo@elte.hu>2008-12-27 09:29:22 +0100
commit793f7b12a0c95e7bfec1badf9628043fb78fd440 (patch)
tree1ace93d9f2bbed43b4594e6bacf75c51ffebf417 /kernel/irq/handle.c
parent8b07cd44511f3aa78dd912cca6493275a6787dc5 (diff)
downloadop-kernel-dev-793f7b12a0c95e7bfec1badf9628043fb78fd440.zip
op-kernel-dev-793f7b12a0c95e7bfec1badf9628043fb78fd440.tar.gz
sparseirq: fix desc->lock init
Impact: cleanup init_one_irq_desc() does not initialize the desc->lock properly - you cannot init a lock by memcpying some other lock on it. This happens to work right now (because irq_desc_init is never in use), but it's a dangerous construct nevertheless, so fix it. Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/irq/handle.c')
-rw-r--r--kernel/irq/handle.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 06b05a4..893da67 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -93,6 +93,8 @@ void __attribute__((weak)) arch_init_chip_data(struct irq_desc *desc, int cpu)
static void init_one_irq_desc(int irq, struct irq_desc *desc, int cpu)
{
memcpy(desc, &irq_desc_init, sizeof(struct irq_desc));
+
+ spin_lock_init(&desc->lock);
desc->irq = irq;
#ifdef CONFIG_SMP
desc->cpu = cpu;
OpenPOWER on IntegriCloud