summaryrefslogtreecommitdiffstats
path: root/kernel/futex.c
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2009-05-20 09:22:40 +0200
committerThomas Gleixner <tglx@linutronix.de>2009-05-20 10:28:45 +0200
commit1c840c14906d4ddf66c1f4f5daea059aad951c82 (patch)
tree3c71d3d67c590df598098f5cdb79151359ff2ce4 /kernel/futex.c
parentc8b15a706d921baed3195407e4f55270112bb3c6 (diff)
downloadop-kernel-dev-1c840c14906d4ddf66c1f4f5daea059aad951c82.zip
op-kernel-dev-1c840c14906d4ddf66c1f4f5daea059aad951c82.tar.gz
futex: fix restart for early wakeup in futex_wait_requeue_pi()
The futex_wait_requeue_pi op should restart unconditionally like futex_lock_pi. The user of that function e.g. pthread_cond_wait can not be interrupted so we do not care about the SA_RESTART flag of the signal. Clean up the FIXMEs. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/futex.c')
-rw-r--r--kernel/futex.c13
1 files changed, 3 insertions, 10 deletions
diff --git a/kernel/futex.c b/kernel/futex.c
index 381125a..2aa216e 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -2060,7 +2060,7 @@ pi_faulted:
*
* Returns
* 0 - no early wakeup detected
- * <0 - -ETIMEDOUT or -ERESTARTSYS (FIXME: or ERESTARTNOINTR?)
+ * <0 - -ETIMEDOUT or -ERESTARTNOINTR
*/
static inline
int handle_early_requeue_pi_wakeup(struct futex_hash_bucket *hb,
@@ -2087,15 +2087,8 @@ int handle_early_requeue_pi_wakeup(struct futex_hash_bucket *hb,
if (timeout && !timeout->task)
ret = -ETIMEDOUT;
- else {
- /*
- * We expect signal_pending(current), but another
- * thread may have handled it for us already.
- */
- /* FIXME: ERESTARTSYS or ERESTARTNOINTR? Do we care if
- * the user specified SA_RESTART or not? */
- ret = -ERESTARTSYS;
- }
+ else
+ ret = -ERESTARTNOINTR;
}
return ret;
}
OpenPOWER on IntegriCloud