diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2010-05-26 14:43:21 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-27 09:12:47 -0700 |
| commit | 6e1be45aa6ba6a36c0312f65ecf311135c73001d (patch) | |
| tree | 3ea540e0ee249259e40e26c38215981b466075ad /kernel/fork.c | |
| parent | 97101eb41d0d3c97543878ce40e0b8a8b2747ed7 (diff) | |
| download | op-kernel-dev-6e1be45aa6ba6a36c0312f65ecf311135c73001d.zip op-kernel-dev-6e1be45aa6ba6a36c0312f65ecf311135c73001d.tar.gz | |
check_unshare_flags: kill the bogus CLONE_SIGHAND/sig->count check
check_unshare_flags(CLONE_SIGHAND) adds CLONE_THREAD to *flags_ptr if the
task is multithreaded to ensure unshare_thread() will fail.
Not only this is a bit strange way to return the error, this is absolutely
meaningless. If signal->count > 1 then sighand->count must be also > 1,
and unshare_sighand() will fail anyway.
In fact, all CLONE_THREAD/SIGHAND/VM checks inside sys_unshare() do not
look right. Fortunately this code doesn't really work anyway.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Acked-by: Roland McGrath <roland@redhat.com>
Cc: Veaceslav Falico <vfalico@redhat.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/fork.c')
| -rw-r--r-- | kernel/fork.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/kernel/fork.c b/kernel/fork.c index 7701470..40cd099 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1518,14 +1518,6 @@ static void check_unshare_flags(unsigned long *flags_ptr) *flags_ptr |= CLONE_SIGHAND; /* - * If unsharing signal handlers and the task was created - * using CLONE_THREAD, then must unshare the thread - */ - if ((*flags_ptr & CLONE_SIGHAND) && - (atomic_read(¤t->signal->count) > 1)) - *flags_ptr |= CLONE_THREAD; - - /* * If unsharing namespace, must also unshare filesystem information. */ if (*flags_ptr & CLONE_NEWNS) |
