summaryrefslogtreecommitdiffstats
path: root/kernel/exit.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@tv-sign.ru>2005-10-24 14:34:03 +0400
committerLinus Torvalds <torvalds@g5.osdl.org>2005-10-24 08:12:35 -0700
commit3de463c7d9d58f8cf3395268230cb20a4c15bffa (patch)
tree20ba1584eefb7ed75f6f8536f40e55966294cf4f /kernel/exit.c
parent108150ea78003044e41150c75259447b2c0953b6 (diff)
downloadop-kernel-dev-3de463c7d9d58f8cf3395268230cb20a4c15bffa.zip
op-kernel-dev-3de463c7d9d58f8cf3395268230cb20a4c15bffa.tar.gz
[PATCH] posix-timers: remove false BUG_ON() from run_posix_cpu_timers()
do_exit() clears ->it_##clock##_expires, but nothing prevents another cpu to attach the timer to exiting process after that. After exit_notify() does 'write_unlock_irq(&tasklist_lock)' and before do_exit() calls 'schedule() local timer interrupt can find tsk->exit_state != 0. If that state was EXIT_DEAD (or another cpu does sys_wait4) interrupted task has ->signal == NULL. At this moment exiting task has no pending cpu timers, they were cleaned up in __exit_signal()->posix_cpu_timers_exit{,_group}(), so we can just return from irq. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel/exit.c')
-rw-r--r--kernel/exit.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/kernel/exit.c b/kernel/exit.c
index 3b25b18..4897977 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -825,14 +825,6 @@ fastcall NORET_TYPE void do_exit(long code)
tsk->flags |= PF_EXITING;
- /*
- * Make sure we don't try to process any timer firings
- * while we are already exiting.
- */
- tsk->it_virt_expires = cputime_zero;
- tsk->it_prof_expires = cputime_zero;
- tsk->it_sched_expires = 0;
-
if (unlikely(in_atomic()))
printk(KERN_INFO "note: %s[%d] exited with preempt_count %d\n",
current->comm, current->pid,
OpenPOWER on IntegriCloud