diff options
author | Oleg Nesterov <oleg@redhat.com> | 2014-03-31 17:24:14 +0200 |
---|---|---|
committer | Oleg Nesterov <oleg@redhat.com> | 2014-04-17 21:58:20 +0200 |
commit | e55848a4f8ee52465771983e144f0c3337776eda (patch) | |
tree | 362ada49af831c34eff21354c90eaeb995091477 /kernel/events | |
parent | 8ad8e9d3fd64f101eed6652964670672d699e563 (diff) | |
download | op-kernel-dev-e55848a4f8ee52465771983e144f0c3337776eda.zip op-kernel-dev-e55848a4f8ee52465771983e144f0c3337776eda.tar.gz |
uprobes/x86: Conditionalize the usage of handle_riprel_insn()
arch_uprobe_analyze_insn() calls handle_riprel_insn() at the start,
but only "0xff" and "default" cases need the UPROBE_FIX_RIP_ logic.
Move the callsite into "default" case and change the "0xff" case to
fall-through.
We are going to add the various hooks to handle the rip-relative
jmp/call instructions (and more), we need this change to enforce the
fact that the new code can not conflict with is_riprel_insn() logic
which, after this change, can only be used by default_xol_ops.
Note: arch_uprobe_abort_xol() still calls handle_riprel_post_xol()
directly. This is fine unless another _xol_ops we may add later will
need to reuse "UPROBE_FIX_RIP_AX|UPROBE_FIX_RIP_CX" bits in ->fixup.
In this case we can add uprobe_xol_ops->abort() hook, which (perhaps)
we will need anyway in the long term.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Jim Keniston <jkenisto@us.ibm.com>
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Diffstat (limited to 'kernel/events')
0 files changed, 0 insertions, 0 deletions