summaryrefslogtreecommitdiffstats
path: root/kernel/compat.c
diff options
context:
space:
mode:
authorTrent Piepho <xyzzy@speakeasy.org>2007-04-27 22:56:29 -0300
committerMauro Carvalho Chehab <mchehab@infradead.org>2007-05-09 10:13:09 -0300
commitbbe2486fe3bd6c7cffaf4123b7e86a55c209ed44 (patch)
tree09520b7aaf5d491a0f954fc8f038d0806663ac5d /kernel/compat.c
parent9d3eb99b36c73843cd73f45dad8ca9dde1ce3888 (diff)
downloadop-kernel-dev-bbe2486fe3bd6c7cffaf4123b7e86a55c209ed44.zip
op-kernel-dev-bbe2486fe3bd6c7cffaf4123b7e86a55c209ed44.tar.gz
V4L/DVB (5571): V4l1-compat: Make VIDIOCSPICT return errors in a useful way
Among other things, VIDIOCSPICT sets the pixel format. Some drivers don't support all formats, e.g. cx88 doesn't support the planar formats. The compat code that translates VIDIOCSPICT into V4L2 ioctls doesn't pass on any errors, so a userspace program doesn't know if it has selected an unsupported pixel format. VIDIOCSPICT sets both the memory capture and overlay formats, and it's possible that one will be set while the other will fail, e.g. cx88 doesn't even support overlay. Also, trying to set the overlay format will fail for non-root users. Signed-off-by: Trent Piepho <xyzzy@speakeasy.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'kernel/compat.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud