diff options
author | Joe Perches <joe@perches.com> | 2015-09-09 15:37:58 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-09-10 13:29:01 -0700 |
commit | c5595fa2f1ce3c1a74dbd2ddc949257e80d81dc0 (patch) | |
tree | 3351ed229a4f64df859ad49de118210dd50fa367 /kernel/async.c | |
parent | 54507b5183cc4f8e4f1a58a312e1f30c130658b7 (diff) | |
download | op-kernel-dev-c5595fa2f1ce3c1a74dbd2ddc949257e80d81dc0.zip op-kernel-dev-c5595fa2f1ce3c1a74dbd2ddc949257e80d81dc0.tar.gz |
checkpatch: add constant comparison on left side test
"CONST <comparison> variable" checks like:
if (NULL != foo)
and
while (0 < bar(...))
where a constant (or what appears to be a constant like an upper case
identifier) is on the left of a comparison are generally preferred to be
written using the constant on the right side like:
if (foo != NULL)
and
while (bar(...) > 0)
Add a test for this.
Add a --fix option too, but only do it when the code is immediately
surrounded by parentheses to avoid misfixing things like "(0 < bar() +
constant)"
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Nicolas Morey Chaisemartin <nmorey@kalray.eu>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/async.c')
0 files changed, 0 insertions, 0 deletions