diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2006-05-22 01:09:24 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2006-06-20 05:25:20 -0400 |
commit | 9044e6bca5a4a575d3c068dfccb5651a2d6a13bc (patch) | |
tree | e0fa2beb83c3ef4e52cc6c6b28ce3173656f4276 /ipc | |
parent | bc0f3b8ebba611291fdaa2864dbffd2d29336c64 (diff) | |
download | op-kernel-dev-9044e6bca5a4a575d3c068dfccb5651a2d6a13bc.zip op-kernel-dev-9044e6bca5a4a575d3c068dfccb5651a2d6a13bc.tar.gz |
[PATCH] fix deadlocks in AUDIT_LIST/AUDIT_LIST_RULES
We should not send a pile of replies while holding audit_netlink_mutex
since we hold the same mutex when we receive commands. As the result,
we can get blocked while sending and sit there holding the mutex while
auditctl is unable to send the next command and get around to receiving
what we'd sent.
Solution: create skb and put them into a queue instead of sending;
once we are done, send what we've got on the list. The former can
be done synchronously while we are handling AUDIT_LIST or AUDIT_LIST_RULES;
we are holding audit_netlink_mutex at that point. The latter is done
asynchronously and without messing with audit_netlink_mutex.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'ipc')
0 files changed, 0 insertions, 0 deletions