summaryrefslogtreecommitdiffstats
path: root/ipc
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@redhat.com>2012-01-07 05:38:38 -0200
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-01-07 11:47:32 -0200
commitb247377ace5d965809d0ba8de158dc2e8d28af77 (patch)
tree94b73fe3b045c8ec0ecad02d25a9c5285caf10a8 /ipc
parentc0fdbd3367b4fd67d754a06292aa121956f98b6f (diff)
downloadop-kernel-dev-b247377ace5d965809d0ba8de158dc2e8d28af77.zip
op-kernel-dev-b247377ace5d965809d0ba8de158dc2e8d28af77.tar.gz
[media] dvb: remove bogus modulation check
This code is wrong as I should have coded it as SYS_DVBC, instead of SYS_DVBS & friends. Anyway, this check has other problems 1) it does some "magic" by assuming that all QAM modulations are below QAM_AUTO; 2) it checks modulation parameters only for one delivery system. Or the core should check invalid parameters for all delivery systems, or it should let the frontend drivers do it; 3) frontend drivers should already be checking for invalid parameters (most of them do it, anyway); 4) not all modulations are mapped at fe->ops.info.caps, so it is not even possible to check for the valid modulations inside the core for some delivery systems; 5) The core check is incomplete anyway: it only checks for a few parameters. If moved into the core other parameters like bandwidth and fec should also be checked; 6) 2nd gen DVB-C uses OFDM. So, that test would fail for it. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'ipc')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud