diff options
author | Paolo Valente <paolo.valente@unimore.it> | 2013-03-05 08:04:58 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-03-06 02:47:05 -0500 |
commit | 624b85fb96206879c8146abdba071222bbd25259 (patch) | |
tree | e6fbd60c1cea8682333422ae797fd9ff83f83ce6 /init | |
parent | 9b99b7e90bf5cd9a88823c49574ba80d92a98262 (diff) | |
download | op-kernel-dev-624b85fb96206879c8146abdba071222bbd25259.zip op-kernel-dev-624b85fb96206879c8146abdba071222bbd25259.tar.gz |
pkt_sched: sch_qfq: fix the update of eligible-group sets
Between two invocations of make_eligible, the system virtual time may
happen to grow enough that, in its binary representation, a bit with
higher order than 31 flips. This happens especially with
TSO/GSO. Before this fix, the mask used in make_eligible was computed
as (1UL<<index_of_last_flipped_bit)-1, whose value is well defined on
a 64-bit architecture, because index_of_flipped_bit <= 63, but is in
general undefined on a 32-bit architecture if index_of_flipped_bit > 31.
The fix just replaces 1UL with 1ULL.
Signed-off-by: Paolo Valente <paolo.valente@unimore.it>
Reviewed-by: Fabio Checconi <fchecconi@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions