diff options
| author | Jiang Liu <jiang.liu@linux.intel.com> | 2014-11-26 09:42:10 +0800 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2014-12-02 13:03:09 +0100 |
| commit | cc4f14aa170d895c9a43bdb56f62070c8a6da908 (patch) | |
| tree | aa8e7d2d6634e0713a9773a77659759f16d967cd /include | |
| parent | 864b94adfcba752aa902ee34497bbe58b97aa8d3 (diff) | |
| download | op-kernel-dev-cc4f14aa170d895c9a43bdb56f62070c8a6da908.zip op-kernel-dev-cc4f14aa170d895c9a43bdb56f62070c8a6da908.tar.gz | |
iommu/vt-d: Fix an off-by-one bug in __domain_mapping()
There's an off-by-one bug in function __domain_mapping(), which may
trigger the BUG_ON(nr_pages < lvl_pages) when
(nr_pages + 1) & superpage_mask == 0
The issue was introduced by commit 9051aa0268dc "intel-iommu: Combine
domain_pfn_mapping() and domain_sg_mapping()", which sets sg_res to
"nr_pages + 1" to avoid some of the 'sg_res==0' code paths.
It's safe to remove extra "+1" because sg_res is only used to calculate
page size now.
Reported-And-Tested-by: Sudeep Dutt <sudeep.dutt@intel.com>
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: <stable@vger.kernel.org> # >= 3.0
Acked-By: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions
