diff options
| author | Jarek Poplawski <jarkao2@gmail.com> | 2008-08-22 03:24:05 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-08-22 03:31:39 -0700 |
| commit | f6e0b239a2657ea8cb67f0d83d0bfdbfd19a481b (patch) | |
| tree | 9d6e3c97a81869fde3958cdbcf431ee3739f9b2c /include | |
| parent | 2540e0511ea17e25831be543cdf9381e6209950d (diff) | |
| download | op-kernel-dev-f6e0b239a2657ea8cb67f0d83d0bfdbfd19a481b.zip op-kernel-dev-f6e0b239a2657ea8cb67f0d83d0bfdbfd19a481b.tar.gz | |
pkt_sched: Fix qdisc list locking
Since some qdiscs call qdisc_tree_decrease_qlen() (so qdisc_lookup())
without rtnl_lock(), adding and deleting from a qdisc list needs
additional locking. This patch adds global spinlock qdisc_list_lock
and wrapper functions for modifying the list. It is considered as a
temporary solution until hfsc_dequeue(), netem_dequeue() and
tbf_dequeue() (or qdisc_tree_decrease_qlen()) are redone.
With feedback from Herbert Xu and David S. Miller.
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/pkt_sched.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h index 853fe83..b786a5b 100644 --- a/include/net/pkt_sched.h +++ b/include/net/pkt_sched.h @@ -78,6 +78,7 @@ extern struct Qdisc *fifo_create_dflt(struct Qdisc *sch, struct Qdisc_ops *ops, extern int register_qdisc(struct Qdisc_ops *qops); extern int unregister_qdisc(struct Qdisc_ops *qops); +extern void qdisc_list_del(struct Qdisc *q); extern struct Qdisc *qdisc_lookup(struct net_device *dev, u32 handle); extern struct Qdisc *qdisc_lookup_class(struct net_device *dev, u32 handle); extern struct qdisc_rate_table *qdisc_get_rtab(struct tc_ratespec *r, |
