diff options
| author | Josef Bacik <jbacik@redhat.com> | 2008-11-26 01:14:26 -0500 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2008-11-26 01:14:26 -0500 |
| commit | e07f7183a486cf9783d1f8c9d2997b5b39eeb2d4 (patch) | |
| tree | 74ed3a563add5fa57e80af03f3f712f2910ac39f /include | |
| parent | 032115fcef837a00336ddf7bda584e89789ea498 (diff) | |
| download | op-kernel-dev-e07f7183a486cf9783d1f8c9d2997b5b39eeb2d4.zip op-kernel-dev-e07f7183a486cf9783d1f8c9d2997b5b39eeb2d4.tar.gz | |
jbd2: improve jbd2 fsync batching
This patch removes the static sleep time in favor of a more self
optimizing approach where we measure the average amount of time it
takes to commit a transaction to disk and the ammount of time a
transaction has been running. If somebody does a sync write or an
fsync() traditionally we would sleep for 1 jiffies, which depending on
the value of HZ could be a significant amount of time compared to how
long it takes to commit a transaction to the underlying storage. With
this patch instead of sleeping for a jiffie, we check to see if the
amount of time this transaction has been running is less than the
average commit time, and if it is we sleep for the delta using
schedule_hrtimeout to give us a higher precision sleep time. This
greatly benefits high end storage where you could end up sleeping for
longer than it takes to commit the transaction and therefore sitting
idle instead of allowing the transaction to be committed by keeping
the sleep time to a minimum so you are sure to always be doing
something.
Signed-off-by: Josef Bacik <jbacik@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/jbd2.h | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h index f366457..ab8cef1 100644 --- a/include/linux/jbd2.h +++ b/include/linux/jbd2.h @@ -638,6 +638,11 @@ struct transaction_s unsigned long t_expires; /* + * When this transaction started, in nanoseconds [no locking] + */ + ktime_t t_start_time; + + /* * How many handles used this transaction? [t_handle_lock] */ int t_handle_count; @@ -939,8 +944,18 @@ struct journal_s struct buffer_head **j_wbuf; int j_wbufsize; + /* + * this is the pid of hte last person to run a synchronous operation + * through the journal + */ pid_t j_last_sync_writer; + /* + * the average amount of time in nanoseconds it takes to commit a + * transaction to disk. [j_state_lock] + */ + u64 j_average_commit_time; + /* This function is called when a transaction is closed */ void (*j_commit_callback)(journal_t *, transaction_t *); |
