summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorTrent Piepho <tpiepho@freescale.com>2008-10-13 10:13:01 +0100
committerRichard Purdie <rpurdie@rpsys.net>2008-10-20 22:34:12 +0100
commit326bb8a5a12c6298a6bf6c74af490b1858b2f12c (patch)
treefd513f4869c4071a585350e458ffd7e8e5f834ac /include
parent132e9306beedd049bc5de037f1996731a2ca3eed (diff)
downloadop-kernel-dev-326bb8a5a12c6298a6bf6c74af490b1858b2f12c.zip
op-kernel-dev-326bb8a5a12c6298a6bf6c74af490b1858b2f12c.tar.gz
leds: Make default trigger fields const
The default_trigger fields of struct gpio_led and thus struct led_classdev are pretty much always assigned from a string literal, which means the string can't be modified. Which is fine, since there is no reason to modify the string and in fact it never is. But they should be marked const to prevent such code from being added, to prevent warnings if -Wwrite-strings is used, when assigned from a constant string other than a string literal (which produces a warning under current kernel compiler flags), and for general good coding practices. Signed-off-by: Trent Piepho <tpiepho@freescale.com> Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
Diffstat (limited to 'include')
-rw-r--r--include/linux/leds.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/leds.h b/include/linux/leds.h
index d41ccb5..d3a73f5 100644
--- a/include/linux/leds.h
+++ b/include/linux/leds.h
@@ -123,7 +123,7 @@ extern void ledtrig_ide_activity(void);
*/
struct led_info {
const char *name;
- char *default_trigger;
+ const char *default_trigger;
int flags;
};
@@ -135,7 +135,7 @@ struct led_platform_data {
/* For the leds-gpio driver */
struct gpio_led {
const char *name;
- char *default_trigger;
+ const char *default_trigger;
unsigned gpio;
u8 active_low;
};
OpenPOWER on IntegriCloud