diff options
author | Satyam Sharma <ssatyam@cse.iitk.ac.in> | 2007-07-09 15:22:23 -0700 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-07-10 22:19:02 -0700 |
commit | 1498b3f1952ae539a7d5c356acf942d5f4c1aece (patch) | |
tree | 70307da369971a106f817c47b0b9cf9d8e3d574f /include | |
parent | 5f1de3ec661e7b08348f565b7ca17586e7e94fc5 (diff) | |
download | op-kernel-dev-1498b3f1952ae539a7d5c356acf942d5f4c1aece.zip op-kernel-dev-1498b3f1952ae539a7d5c356acf942d5f4c1aece.tar.gz |
[NETPOLL]: Fix a leak-n-bug in netpoll_cleanup()
93ec2c723e3f8a216dde2899aeb85c648672bc6b applied excessive duct tape to
the netpoll beast's netpoll_cleanup(), thus substituting one leak with
another, and opening up a little buglet :-)
net_device->npinfo (netpoll_info) is a shared and refcounted object and
cannot simply be set NULL the first time netpoll_cleanup() is called.
Otherwise, further netpoll_cleanup()'s see np->dev->npinfo == NULL and
become no-ops, thus leaking. And it's a bug too: the first call to
netpoll_cleanup() would thus (annoyingly) "disable" other (still alive)
netpolls too. Maybe nobody noticed this because netconsole (only user
of netpoll) never supported multiple netpoll objects earlier.
This is a trivial and obvious one-line fixlet.
Signed-off-by: Satyam Sharma <ssatyam@cse.iitk.ac.in>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions