diff options
author | Tejun Heo <tj@kernel.org> | 2008-10-13 18:45:20 -0500 |
---|---|---|
committer | Eric Van Hensbergen <ericvh@gmail.com> | 2008-10-17 11:04:42 -0500 |
commit | 95820a36516d12dcb49d066dd3d5b187a2557612 (patch) | |
tree | 84ba5869e9f68b3c943e75feb7c634da1c61f47a /include | |
parent | 91b8534fa8f5e01f249b1bf8df0a2540053549ad (diff) | |
download | op-kernel-dev-95820a36516d12dcb49d066dd3d5b187a2557612.zip op-kernel-dev-95820a36516d12dcb49d066dd3d5b187a2557612.tar.gz |
9p: drop broken unused error path from p9_conn_create()
Post p9_fd_poll() error path which checks m->poll_waddr[i] for PTR_ERR
value has the following problems.
* It's completely unused. Error value is set iff NULL @wait_address
has been specified to p9_pollwait() which is guaranteed not to
happen.
* It dereferences @m after deallocating it (introduced by 571ffeaf and
spotted by Raja R Harinath.
* It returned the wrong value on error. It should return
poll_waddr[i] but it returnes poll_waddr (introduced by 571ffeaf).
* p9_mux_poll_stop() doesn't handle PTR_ERR value. It will try to
operate on the PTR_ERR value as if it's a normal pointer and cause
oops.
As the error path is bogus in the first place, there's no reason to
hold onto it. Kill it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Raja R Harinath <harinath@hurrynot.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions