summaryrefslogtreecommitdiffstats
path: root/include/video
diff options
context:
space:
mode:
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>2010-09-09 11:48:01 +0900
committerMark Brown <broonie@opensource.wolfsonmicro.com>2010-09-10 16:07:41 +0100
commitdec6aa49abf73b061b631163cb1e1d803a614d24 (patch)
tree6e4e8010c0ad0bb1eb005364e76fb1bf475cc753 /include/video
parentf4363b7d88e99497e4241397efee09b106d802c4 (diff)
downloadop-kernel-dev-dec6aa49abf73b061b631163cb1e1d803a614d24.zip
op-kernel-dev-dec6aa49abf73b061b631163cb1e1d803a614d24.tar.gz
fbdev: sh_mobile_hdmi: modify flags name to more specific
This patch solve below report from Guennadi 1) > +/* Audio source select */ > +#define HDMI_SRC_MASK (0xF << 0) > +#define HDMI_SRC_I2S (0 << 0) /* default */ > +#define HDMI_SRC_SPDIF (1 << 0) > +#define HDMI_SRC_DSD (2 << 0) > +#define HDMI_SRC_HBR (3 << 0) I would be more specific with these macro names, i.e., include "AUDIO" or "SND" or something similar in them, e.g., HDMI_AUDIO_SRC_I2S. 2) > + case HDMI_SRC_I2S: > + data = (0x0 << 3); > + break; > + case HDMI_SRC_SPDIF: > + data = (0x1 << 3); > + break; > + case HDMI_SRC_DSD: > + data = (0x2 << 3); > + break; > + case HDMI_SRC_HBR: > + data = (0x3 << 3); In all above cases parenthesis are superfluous. Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'include/video')
-rw-r--r--include/video/sh_mobile_hdmi.h10
1 files changed, 5 insertions, 5 deletions
diff --git a/include/video/sh_mobile_hdmi.h b/include/video/sh_mobile_hdmi.h
index 929c2d3..1e1aa54 100644
--- a/include/video/sh_mobile_hdmi.h
+++ b/include/video/sh_mobile_hdmi.h
@@ -23,11 +23,11 @@ struct device;
*/
/* Audio source select */
-#define HDMI_SRC_MASK (0xF << 0)
-#define HDMI_SRC_I2S (0 << 0) /* default */
-#define HDMI_SRC_SPDIF (1 << 0)
-#define HDMI_SRC_DSD (2 << 0)
-#define HDMI_SRC_HBR (3 << 0)
+#define HDMI_SND_SRC_MASK (0xF << 0)
+#define HDMI_SND_SRC_I2S (0 << 0) /* default */
+#define HDMI_SND_SRC_SPDIF (1 << 0)
+#define HDMI_SND_SRC_DSD (2 << 0)
+#define HDMI_SND_SRC_HBR (3 << 0)
struct sh_mobile_hdmi_info {
struct sh_mobile_lcdc_chan_cfg *lcd_chan;
OpenPOWER on IntegriCloud