diff options
author | Alexander Duyck <alexander.h.duyck@redhat.com> | 2015-03-31 14:19:10 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-04-03 12:52:29 -0400 |
commit | 2e7056c433216f406b90a003aa0ba42e19d3bdcf (patch) | |
tree | 9839bafb2d86ac847b062635dca3b60514fb26a8 /include/uapi | |
parent | 5c5e0ad3f9dca572198f3ad6fbf7dc2e647bcf0c (diff) | |
download | op-kernel-dev-2e7056c433216f406b90a003aa0ba42e19d3bdcf.zip op-kernel-dev-2e7056c433216f406b90a003aa0ba42e19d3bdcf.tar.gz |
jhash: Update jhash_[321]words functions to use correct initval
Looking over the implementation for jhash2 and comparing it to jhash_3words
I realized that the two hashes were in fact very different. Doing a bit of
digging led me to "The new jhash implementation" in which lookup2 was
supposed to have been replaced with lookup3.
In reviewing the patch I noticed that jhash2 had originally initialized a
and b to JHASH_GOLDENRATIO and c to initval, but after the patch a, b, and
c were initialized to initval + (length << 2) + JHASH_INITVAL. However the
changes in jhash_3words simply replaced the initialization of a and b with
JHASH_INITVAL.
This change corrects what I believe was an oversight so that a, b, and c in
jhash_3words all have the same value added consisting of initval + (length
<< 2) + JHASH_INITVAL so that jhash2 and jhash_3words will now produce the
same hash result given the same inputs.
Fixes: 60d509c823cca ("The new jhash implementation")
Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/uapi')
0 files changed, 0 insertions, 0 deletions