summaryrefslogtreecommitdiffstats
path: root/include/uapi
diff options
context:
space:
mode:
authorMike Christie <mchristi@redhat.com>2017-06-12 01:34:28 -0500
committerNicholas Bellinger <nab@linux-iscsi.org>2017-07-06 23:11:36 -0700
commit2d76443e02f260d7a5bd0ede1851ae5534f0c68d (patch)
tree537aa19cfd1d41b92a2fbf9e354c1b3258208262 /include/uapi
parent5f572526a18418258bfa137e3353656c25439500 (diff)
downloadop-kernel-dev-2d76443e02f260d7a5bd0ede1851ae5534f0c68d.zip
op-kernel-dev-2d76443e02f260d7a5bd0ede1851ae5534f0c68d.tar.gz
tcmu: reconfigure netlink attr changes
1. TCMU_ATTR_TYPE is too generic when it describes only the reconfiguration type, so rename to TCMU_ATTR_RECONFIG_TYPE. 2. Only return the reconfig type when it is a TCMU_CMD_RECONFIG_DEVICE command. 3. CONFIG_* type is not needed. We can pass the value along with an ATTR to userspace, so it does not need to read sysfs/configfs. 4. Fix leak in tcmu_dev_path_store and rename to dev_config to reflect it is more than just a path that can be changed. 6. Don't update kernel struct value if netlink sending fails. Signed-off-by: Mike Christie <mchristi@redhat.com> Reviewed-by: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'include/uapi')
-rw-r--r--include/uapi/linux/target_core_user.h12
1 files changed, 4 insertions, 8 deletions
diff --git a/include/uapi/linux/target_core_user.h b/include/uapi/linux/target_core_user.h
index 5b00e35..4bfc9a1 100644
--- a/include/uapi/linux/target_core_user.h
+++ b/include/uapi/linux/target_core_user.h
@@ -139,16 +139,12 @@ enum tcmu_genl_attr {
TCMU_ATTR_UNSPEC,
TCMU_ATTR_DEVICE,
TCMU_ATTR_MINOR,
- TCMU_ATTR_TYPE,
+ TCMU_ATTR_PAD,
+ TCMU_ATTR_DEV_CFG,
+ TCMU_ATTR_DEV_SIZE,
+ TCMU_ATTR_WRITECACHE,
__TCMU_ATTR_MAX,
};
#define TCMU_ATTR_MAX (__TCMU_ATTR_MAX - 1)
-enum tcmu_reconfig_types {
- NO_RECONFIG,
- CONFIG_PATH,
- CONFIG_SIZE,
- CONFIG_WRITECACHE,
-};
-
#endif
OpenPOWER on IntegriCloud