diff options
| author | Jesper Dangaard Brouer <brouer@redhat.com> | 2017-08-17 18:22:37 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-08-18 16:18:40 -0700 |
| commit | 4c03bdd7b5c084c3c6973cb2419edac5363c051f (patch) | |
| tree | 77e091a3b5de3c55433947ec41891ba2b1e52019 /include/trace | |
| parent | d2cee2e5d0106abb5da25f393b3c50e0bb01f7f9 (diff) | |
| download | op-kernel-dev-4c03bdd7b5c084c3c6973cb2419edac5363c051f.zip op-kernel-dev-4c03bdd7b5c084c3c6973cb2419edac5363c051f.tar.gz | |
xdp: adjust xdp redirect tracepoint to include return error code
The return error code need to be included in the tracepoint
xdp:xdp_redirect, else its not possible to distinguish successful or
failed XDP_REDIRECT transmits.
XDP have no queuing mechanism. Thus, it is fairly easily to overrun a
NIC transmit queue. The eBPF program invoking helpers (bpf_redirect
or bpf_redirect_map) to redirect a packet doesn't get any feedback
whether the packet was actually transmitted.
Info on failed transmits in the tracepoint xdp:xdp_redirect, is
interesting as this opens for providing a feedback-loop to the
receiving XDP program.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/trace')
| -rw-r--r-- | include/trace/events/xdp.h | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h index 7b1eb7b..0e42e69 100644 --- a/include/trace/events/xdp.h +++ b/include/trace/events/xdp.h @@ -53,15 +53,16 @@ TRACE_EVENT(xdp_redirect, TP_PROTO(const struct net_device *from, const struct net_device *to, - const struct bpf_prog *xdp, u32 act), + const struct bpf_prog *xdp, u32 act, int err), - TP_ARGS(from, to, xdp, act), + TP_ARGS(from, to, xdp, act, err), TP_STRUCT__entry( __string(name_from, from->name) __string(name_to, to->name) __array(u8, prog_tag, 8) __field(u32, act) + __field(int, err) ), TP_fast_assign( @@ -70,12 +71,14 @@ TRACE_EVENT(xdp_redirect, __assign_str(name_from, from->name); __assign_str(name_to, to->name); __entry->act = act; + __entry->err = err; ), - TP_printk("prog=%s from=%s to=%s action=%s", + TP_printk("prog=%s from=%s to=%s action=%s err=%d", __print_hex_str(__entry->prog_tag, 8), __get_str(name_from), __get_str(name_to), - __print_symbolic(__entry->act, __XDP_ACT_SYM_TAB)) + __print_symbolic(__entry->act, __XDP_ACT_SYM_TAB), + __entry->err) ); #endif /* _TRACE_XDP_H */ |
