diff options
| author | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-05-09 12:42:09 -0700 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-05-09 15:08:47 -0700 |
| commit | 11e764bd5ed4bb930e0ec5dd161df58307507347 (patch) | |
| tree | fa753a950d19c2ef848c50c60f71019dcb912e74 /include/target | |
| parent | 2301917044b96fda41f794011368e623a9b7a435 (diff) | |
| download | op-kernel-dev-11e764bd5ed4bb930e0ec5dd161df58307507347.zip op-kernel-dev-11e764bd5ed4bb930e0ec5dd161df58307507347.tar.gz | |
target: Remove max_sectors device attribute for modern se_task less code
This patch removes the original usage of dev_attr->max_sectors in favor of
dev_attr->hw_max_sectors that is now being enforced by target core from
within transport_generic_cmd_sequencer() for SCF_SCSI_DATA_SG_IO_CDB ops.
After the recent se_task removal patches from hch, this value for IBLOCK
backends being set via configfs by userspace from an saved max_sectors
value that is turning out to be problematic, so it makes sense to go ahead
and remove this now legacy attribute all-together.
This patch also continues to make se_dev_set_default_attribs() do
(sectors / block_size) alignment for what actually get used by
target_core_mod to be safe here, following the same alignment currently
used by fabric_max_sectors.
Reported-by: Andy Grover <agrover@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'include/target')
| -rw-r--r-- | include/target/target_core_base.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index 927771a..1fe9111f 100644 --- a/include/target/target_core_base.h +++ b/include/target/target_core_base.h @@ -708,7 +708,6 @@ struct se_dev_attrib { u32 hw_block_size; u32 block_size; u32 hw_max_sectors; - u32 max_sectors; u32 fabric_max_sectors; u32 optimal_sectors; u32 hw_queue_depth; |
