summaryrefslogtreecommitdiffstats
path: root/include/sound/seq_midi_emul.h
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2015-04-28 17:11:44 +0200
committerTakashi Iwai <tiwai@suse.de>2015-04-28 17:45:45 +0200
commit1c94e65c668f44d2c69ae7e7fc268ab3268fba3e (patch)
tree14e8a5875c542973577f789d47a1f7d9419ed6fa /include/sound/seq_midi_emul.h
parent30e5f003ff4b2be86f71733b6c9b11355d66584c (diff)
downloadop-kernel-dev-1c94e65c668f44d2c69ae7e7fc268ab3268fba3e.zip
op-kernel-dev-1c94e65c668f44d2c69ae7e7fc268ab3268fba3e.tar.gz
ALSA: emux: Fix mutex deadlock in OSS emulation
The OSS emulation in synth-emux helper has a potential AB/BA deadlock at the simultaneous closing and opening: close -> snd_seq_release() -> sne_seq_free_client() -> snd_seq_delete_all_ports(): takes client->ports_mutex -> port_delete() -> snd_emux_unuse(): takes emux->register_mutex open -> snd_seq_oss_open() -> snd_emux_open_seq_oss(): takes emux->register_mutex -> snd_seq_event_port_attach() -> snd_seq_create_port(): takes client->ports_mutex This patch addresses the deadlock by reducing the rance taking emux->register_mutex in snd_emux_open_seq_oss(). The lock is needed for the refcount handling, so move it locally. The calls in emux_seq.c are already with the mutex, thus they are replaced with the version without mutex lock/unlock. Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'include/sound/seq_midi_emul.h')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud