diff options
| author | James Bottomley <jbottomley@parallels.com> | 2013-11-11 13:44:53 +0100 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2013-12-19 07:39:02 -0800 |
| commit | 2451079bc2ae1334058be8babd44be03ecfa7041 (patch) | |
| tree | 6c1e7c36d47108fb094a8e97062b56fe573e16e8 /include/scsi | |
| parent | 1a4049ddfdaa75db7c9927dbc4d991bd73f923a0 (diff) | |
| download | op-kernel-dev-2451079bc2ae1334058be8babd44be03ecfa7041.zip op-kernel-dev-2451079bc2ae1334058be8babd44be03ecfa7041.tar.gz | |
[SCSI] Fix erratic device offline during EH
Commit 18a4d0a22ed6c54b67af7718c305cd010f09ddf8
(Handle disk devices which can not process medium access commands)
was introduced to offline any device which cannot process medium
access commands.
However, commit 3eef6257de48ff84a5d98ca533685df8a3beaeb8
(Reduce error recovery time by reducing use of TURs) reduced
the number of TURs by sending it only on the first failing
command, which might or might not be a medium access command.
So in combination this results in an erratic device offlining
during EH; if the command where the TUR was sent upon happens
to be a medium access command the device will be set offline,
if not everything proceeds as normal.
This patch moves the check to the final test, eliminating
this problem.
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'include/scsi')
| -rw-r--r-- | include/scsi/scsi_driver.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/scsi/scsi_driver.h b/include/scsi/scsi_driver.h index d443aa0..20fdfc2 100644 --- a/include/scsi/scsi_driver.h +++ b/include/scsi/scsi_driver.h @@ -16,7 +16,7 @@ struct scsi_driver { void (*rescan)(struct device *); int (*done)(struct scsi_cmnd *); - int (*eh_action)(struct scsi_cmnd *, unsigned char *, int, int); + int (*eh_action)(struct scsi_cmnd *, int); }; #define to_scsi_driver(drv) \ container_of((drv), struct scsi_driver, gendrv) |
