diff options
| author | Yi Zou <yi.zou@intel.com> | 2009-07-29 17:05:32 -0700 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@suse.de> | 2009-08-22 17:52:10 -0500 |
| commit | 537029f8e950776951ca2a3fe30121d5c05643d1 (patch) | |
| tree | 98a6cbdf513eb5c1d73c2b356dc33f65e7cfd899 /include/scsi/fc_frame.h | |
| parent | 15a521b4243f3d61971f8422f3e514ef009a42b8 (diff) | |
| download | op-kernel-dev-537029f8e950776951ca2a3fe30121d5c05643d1.zip op-kernel-dev-537029f8e950776951ca2a3fe30121d5c05643d1.tar.gz | |
[SCSI] libfc: Remove FC_FRAME_SG_LEN in fc_fcp_send_data
FC_FRAME_SG_LEN is 4 which is too small when offload is enabled. Actually, the
WARN_ON() in fc_fcp_send_data() should be:
WARN_ON(skb_shinfo(fp_skb(fp))->nr_frags > MAX_SKB_FRAGS);
But since we will not get anything more than 64K anyway, so there is no need
to do this anyway here. Therefore, I am getting rid of FC_FRAME_SG_LEN here
and the WARN_ON here.
Signed-off-by: Yi Zou <yi.zou@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'include/scsi/fc_frame.h')
| -rw-r--r-- | include/scsi/fc_frame.h | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/include/scsi/fc_frame.h b/include/scsi/fc_frame.h index 5951105..c35d238 100644 --- a/include/scsi/fc_frame.h +++ b/include/scsi/fc_frame.h @@ -37,13 +37,6 @@ #define FC_FRAME_HEADROOM 32 /* headroom for VLAN + FCoE headers */ #define FC_FRAME_TAILROOM 8 /* trailer space for FCoE */ -/* - * Information about an individual fibre channel frame received or to be sent. - * The buffer may be in up to 4 additional non-contiguous sections, - * but the linear section must hold the frame header. - */ -#define FC_FRAME_SG_LEN 4 /* scatter/gather list maximum length */ - #define fp_skb(fp) (&((fp)->skb)) #define fr_hdr(fp) ((fp)->skb.data) #define fr_len(fp) ((fp)->skb.len) |
