diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-11-13 01:24:04 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-11-14 00:12:26 -0500 |
| commit | 2a24444f8f2bea694003e3eac5c2f8d9a386bdc5 (patch) | |
| tree | ef283db22c931c518ac6c0b8bca2e23dd62a7736 /include/net/snmp.h | |
| parent | 3d249d4ca7d0ed6629a135ea1ea21c72286c0d80 (diff) | |
| download | op-kernel-dev-2a24444f8f2bea694003e3eac5c2f8d9a386bdc5.zip op-kernel-dev-2a24444f8f2bea694003e3eac5c2f8d9a386bdc5.tar.gz | |
ipv6: reduce percpu needs for icmpv6msg mibs
Reading /proc/net/snmp6 on a machine with a lot of cpus is very
expensive (can be ~88000 us).
This is because ICMPV6MSG MIB uses 4096 bytes per cpu, and folding
values for all possible cpus can read 16 Mbytes of memory (32MBytes on
non x86 arches)
ICMP messages are not considered as fast path on a typical server, and
eventually few cpus handle them anyway. We can afford an atomic
operation instead of using percpu data.
This saves 4096 bytes per cpu and per network namespace.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/snmp.h')
| -rw-r--r-- | include/net/snmp.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/snmp.h b/include/net/snmp.h index 0feafa6..2f65e16 100644 --- a/include/net/snmp.h +++ b/include/net/snmp.h @@ -84,7 +84,7 @@ struct icmpv6_mib_device { #define ICMP6MSG_MIB_MAX __ICMP6MSG_MIB_MAX /* per network ns counters */ struct icmpv6msg_mib { - unsigned long mibs[ICMP6MSG_MIB_MAX]; + atomic_long_t mibs[ICMP6MSG_MIB_MAX]; }; /* per device counters, (shared on all cpus) */ struct icmpv6msg_mib_device { |
