summaryrefslogtreecommitdiffstats
path: root/include/mtd
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-03-29 22:33:28 -0700
committerDavid S. Miller <davem@davemloft.net>2010-03-29 22:33:28 -0700
commitc4a3987fa075b2d15ebc3d59b01fb7ed403cd3e1 (patch)
treeb751350fb5c0abc2c8f636dae7429d409300be7f /include/mtd
parent9e8307ecaf9f8c8b5b3b22145021204c4e73114a (diff)
downloadop-kernel-dev-c4a3987fa075b2d15ebc3d59b01fb7ed403cd3e1.zip
op-kernel-dev-c4a3987fa075b2d15ebc3d59b01fb7ed403cd3e1.tar.gz
drivers/serial/sunsu.c: Correct use after free
The of_iounmap is at the out_unmap label, but at that point up has already been freed. The free cannot be moved to the out_unmap label, because that label is reachable from cases where up should not be freed. So the call to of_iounmap is just duplicated, and the goto converted to a return. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,e; identifier f; iterator I; statement S; @@ *kfree(x); ... when != &x when != x = e when != I(x,...) S *x->f // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/mtd')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud