summaryrefslogtreecommitdiffstats
path: root/include/linux
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2006-05-31 18:27:32 +0900
committerTejun Heo <htejun@gmail.com>2006-05-31 18:27:32 +0900
commit72fa4b742b327bd1b07985d79a61c61dbd9fd4e6 (patch)
tree50d95fcf58e709b12510151e8e1cae8d8cb2538e /include/linux
parent3ef3b43d5633d30fa3f033f62094ec2e9c5b8376 (diff)
downloadop-kernel-dev-72fa4b742b327bd1b07985d79a61c61dbd9fd4e6.zip
op-kernel-dev-72fa4b742b327bd1b07985d79a61c61dbd9fd4e6.tar.gz
[PATCH] libata-hp-prep: make some ata_device fields persistent
Lifetimes of some fields span over device plugging/unplugging. This patch moves such persistent fields to the top of ata_device and separate them with ATA_DEVICE_CLEAR_OFFSET. Fields above the offset are initialized once during host initializatino while all other fields are cleared before hotplugging. Currently ->ap, devno and part of flags are persistent. Note that flags is partially cleared while holding host_set lock. This is to synchronize with later warm plug implementation which will record hotplug request in dev->flags. Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'include/linux')
-rw-r--r--include/linux/libata.h11
1 files changed, 9 insertions, 2 deletions
diff --git a/include/linux/libata.h b/include/linux/libata.h
index d4a668c..aa14eda 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -130,6 +130,7 @@ enum {
ATA_DFLAG_CFG_MASK = (1 << 8) - 1,
ATA_DFLAG_PIO = (1 << 8), /* device currently in PIO mode */
+ ATA_DFLAG_INIT_MASK = (1 << 16) - 1,
ATA_DFLAG_DETACH = (1 << 16),
ATA_DFLAG_DETACHED = (1 << 17),
@@ -410,10 +411,11 @@ struct ata_ering {
struct ata_device {
struct ata_port *ap;
- u64 n_sectors; /* size of device, if ATA */
+ unsigned int devno; /* 0 or 1 */
unsigned long flags; /* ATA_DFLAG_xxx */
+ /* n_sector is used as CLEAR_OFFSET, read comment above CLEAR_OFFSET */
+ u64 n_sectors; /* size of device, if ATA */
unsigned int class; /* ATA_DEV_xxx */
- unsigned int devno; /* 0 or 1 */
u16 id[ATA_ID_WORDS]; /* IDENTIFY xxx DEVICE data */
u8 pio_mode;
u8 dma_mode;
@@ -439,6 +441,11 @@ struct ata_device {
struct ata_ering ering;
};
+/* Offset into struct ata_device. Fields above it are maintained
+ * acress device init. Fields below are zeroed.
+ */
+#define ATA_DEVICE_CLEAR_OFFSET offsetof(struct ata_device, n_sectors)
+
struct ata_eh_info {
struct ata_device *dev; /* offending device */
u32 serror; /* SError from LLDD */
OpenPOWER on IntegriCloud